This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Use configuration flag to log custom step event for GetStartedViewController
#724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selanthiraiyan
changed the title
step event for GetStartedViewController
2 tasks
5 tasks
selanthiraiyan
deleted the
feat/723-configuration-flag-for-woo-analytics-step
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #723
Description
Previously in #674 we introduced a new step value
enter_email_addressforGetStartedViewController.This was added to differentiate between
GetStartedViewControllerandSiteAddressViewControllerin Woo mobile app. Those two screens had the sameflowandstepvalue.This new step value change has led to an issue with the WPiOS Looker dashboard (ref: pe5sF9-FU-p2#comment-1542).
To fix the issue, we are introducing a configuration flag in
WordPressAuthenticatorConfigurationto use custom step event only when theuseEnterEmailAddressAsStepValueForGetStartedVCflag is enabled.Testing steps
Follow the testing instructions from
GetStartedViewControllerWordPress-iOS#19940CHANGELOG.mdif necessary.